Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add edge reader by ngql #57

Merged
merged 6 commits into from
Oct 13, 2022
Merged

add edge reader by ngql #57

merged 6 commits into from
Oct 13, 2022

Conversation

MeeCreeps
Copy link

Read subgraph edge data via ngql as input to the nebula-algorithm side

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2022

CLA assistant check
All committers have signed the CLA.

@Nicole00
Copy link
Contributor

Nicole00 commented Sep 3, 2022

Thanks for your idea and pr.
Connector uses java storage client and uses Scan interface to read NebulaGraph's data. The Scan interface has one param named filter, which would resolve your requirement. But sadly this filter param is not implemented yet.
And I thank your pr maybe a business solution, can you push it to branch community_ngql?

@MeeCreeps
Copy link
Author

ok,thanks for your reply, I will push it to bash comunity_ngql
and could you please tell me about the filter ?

@MeeCreeps MeeCreeps changed the base branch from v3.0.0 to community_ngql September 3, 2022 15:02
@Nicole00
Copy link
Contributor

Nicole00 commented Sep 6, 2022

could you please resolve the conflict?

@codecov-commenter
Copy link

Codecov Report

Merging #57 (20f0a8d) into community_ngql (ecdf065) will decrease coverage by 5.50%.
The diff coverage is 12.75%.

@@                 Coverage Diff                  @@
##             community_ngql      #57      +/-   ##
====================================================
- Coverage             73.86%   68.35%   -5.51%     
- Complexity              152      153       +1     
====================================================
  Files                    24       25       +1     
  Lines                  1580     1716     +136     
  Branches                255      278      +23     
====================================================
+ Hits                   1167     1173       +6     
- Misses                  266      395     +129     
- Partials                147      148       +1     
Impacted Files Coverage Δ
...in/scala/com/vesoft/nebula/connector/package.scala 52.09% <0.00%> (-7.17%) ⬇️
...nnector/reader/NebulaNgqlEdgePartitionReader.scala 0.00% <0.00%> (ø)
...soft/nebula/connector/reader/NebulaPartition.scala 66.66% <0.00%> (-33.34%) ⬇️
...t/nebula/connector/reader/NebulaSourceReader.scala 85.71% <0.00%> (-7.39%) ⬇️
...ala/com/vesoft/nebula/connector/NebulaConfig.scala 76.06% <55.17%> (-2.74%) ⬇️
...la/com/vesoft/nebula/connector/NebulaOptions.scala 85.31% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MeeCreeps
Copy link
Author

hi,I resolve the conflict , could you review it

@wey-gu wey-gu requested a review from Nicole00 September 19, 2022 01:36
@wey-gu wey-gu requested a review from caton-hpg September 27, 2022 09:55
@caton-hpg caton-hpg merged commit f887f9b into vesoft-inc:community_ngql Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants